lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR
Date
hi Jakub,

On 11/11/2020 14:32, Richard Cochran wrote:
> On Wed, Nov 11, 2020 at 05:24:41PM +0800, Wang Qing wrote:
>> We always have to update the value of ret, otherwise the error value
>> may be the previous one. And ptp_clock_register() never return NULL
>> when PTP_1588_CLOCK enable.
>
> NAK.
>
> Your code must handle the possibility that ptp_clock_register() can
> return NULL. Why?
>
> 1. Because that follows the documented API.
>
> 2. Because people will copy/paste this driver.
>
> 3. Because the Kconfig for your driver can change without warning.

Following Richard's comments v1 of the patch has to be applied [1].
I've also added my Reviewed-by there.

[1] https://lore.kernel.org/patchwork/patch/1334067/
--
Best regards,
grygorii

\
 
 \ /
  Last update: 2020-11-11 14:25    [W:0.059 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site