Messages in this thread | | | Date | Wed, 11 Nov 2020 01:34:11 -0800 | From | John Fastabend <> | Subject | Re: [PATCH v3] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id |
| |
Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 9:03 PM <xiakaixu1987@gmail.com> wrote: > > > > From: Kaixu Xia <kaixuxia@tencent.com> > > > > The unsigned variable datasec_id is assigned a return value from the call > > to check_pseudo_btf_id(), which may return negative error code. > > > > Fixes coccicheck warning: > > > > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0 > > > > Reported-by: Tosk Robot <tencent_os_robot@tencent.com> > > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> > > --- > > Looks good. > > Acked-by: Andrii Nakryiko <andrii@kernel.org> > > [...]
Acked-by: John Fastabend <john.fastabend@gmail.com>
| |