lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] arm64: dts: qcom: sc7180: Set 'polling-delay-passive' for thermal zones back to 250 ms
Date
Commit 22337b91022d ("arm64: dts: qcom: sc7180: Changed polling mode
in Thermal-zones node") sets both 'polling-delay' and
'polling-delay-passive' to zero with the rationale that TSENS interrupts
are enabled. A TSENS interrupt fires when the temperature of a thermal
zone reaches a trip point, which makes regular polling below the passive
trip point temperature unnecessary. However the situation is different
when passive cooling is active, regular polling is still needed to
trigger a periodic evaluation of the thermal zone by the thermal governor.

Change 'polling-delay-passive' back to the original value of 250 ms.
Commit 2315ae70af95 ("arm64: dts: qcom: sc7180: Add gpu cooling
support") recently changed the value for the GPU thermal zones from
zero to 100 ms, also set it to 250 ms for uniformity. If some zones
really need different values these can be changed in dedicated patches.

Fixes: 22337b91022d ("arm64: dts: qcom: sc7180: Changed polling mode in Thermal-zones node")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---

arch/arm64/boot/dts/qcom/sc7180.dtsi | 50 ++++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 4e7e58c63285..2f454686a883 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3520,7 +3520,7 @@ lpass_hm: clock-controller@63000000 {

thermal-zones {
cpu0-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 1>;
@@ -3569,7 +3569,7 @@ map1 {
};

cpu1-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 2>;
@@ -3618,7 +3618,7 @@ map1 {
};

cpu2-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 3>;
@@ -3667,7 +3667,7 @@ map1 {
};

cpu3-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 4>;
@@ -3716,7 +3716,7 @@ map1 {
};

cpu4-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 5>;
@@ -3765,7 +3765,7 @@ map1 {
};

cpu5-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 6>;
@@ -3814,7 +3814,7 @@ map1 {
};

cpu6-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 9>;
@@ -3855,7 +3855,7 @@ map1 {
};

cpu7-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 10>;
@@ -3896,7 +3896,7 @@ map1 {
};

cpu8-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 11>;
@@ -3937,7 +3937,7 @@ map1 {
};

cpu9-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 12>;
@@ -3978,7 +3978,7 @@ map1 {
};

aoss0-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 0>;
@@ -3999,7 +3999,7 @@ aoss0_crit: aoss0_crit {
};

cpuss0-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 7>;
@@ -4019,7 +4019,7 @@ cpuss0_crit: cluster0_crit {
};

cpuss1-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 8>;
@@ -4039,7 +4039,7 @@ cpuss1_crit: cluster0_crit {
};

gpuss0-thermal {
- polling-delay-passive = <100>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 13>;
@@ -4067,7 +4067,7 @@ map0 {
};

gpuss1-thermal {
- polling-delay-passive = <100>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens0 14>;
@@ -4095,7 +4095,7 @@ map0 {
};

aoss1-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 0>;
@@ -4116,7 +4116,7 @@ aoss1_crit: aoss1_crit {
};

cwlan-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 1>;
@@ -4137,7 +4137,7 @@ cwlan_crit: cwlan_crit {
};

audio-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 2>;
@@ -4158,7 +4158,7 @@ audio_crit: audio_crit {
};

ddr-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 3>;
@@ -4179,7 +4179,7 @@ ddr_crit: ddr_crit {
};

q6-hvx-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 4>;
@@ -4200,7 +4200,7 @@ q6_hvx_crit: q6_hvx_crit {
};

camera-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 5>;
@@ -4221,7 +4221,7 @@ camera_crit: camera_crit {
};

mdm-core-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 6>;
@@ -4242,7 +4242,7 @@ mdm_crit: mdm_crit {
};

mdm-dsp-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 7>;
@@ -4263,7 +4263,7 @@ mdm_dsp_crit: mdm_dsp_crit {
};

npu-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 8>;
@@ -4284,7 +4284,7 @@ npu_crit: npu_crit {
};

video-thermal {
- polling-delay-passive = <0>;
+ polling-delay-passive = <250>;
polling-delay = <0>;

thermal-sensors = <&tsens1 9>;
--
2.29.2.222.g5d2a92d10f8-goog
\
 
 \ /
  Last update: 2020-11-11 21:04    [W:0.041 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site