lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] printk: ringbuffer: Convert function argument to local variable
Date
On 2020-11-10, Nikolay Borisov <nborisov@suse.com> wrote:
> data_alloc's 2nd argument is always rb::text_data_ring and that functino
> always takes a struct printk_ringbuffer. Instead of passing the data
> ring buffer as an argument simply make it a local variable.

This is a relic of when we had a second data ring (for
dictionaries). The patch is a nice cleanup, but there are actually
several functions that could use this exact same cleanup:

- data_make_reusable()
- data_push_tail()
- data_alloc()
- data_realloc()

Perhaps we should fix them all in a single patch?

John Ogness

\
 
 \ /
  Last update: 2020-11-10 14:14    [W:0.040 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site