lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RESEND PATCH 02/19] pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON
    Date
    From: Yangtao Li <frank@allwinnertech.com>

    The interrupt descriptor cannot be found in the interrupt processing
    function, and this situation cannot happen when the system is running
    normally. It doesn't seem right to return directly to the status of not
    handling gic. In this case, it must be a bug, let's mark it with
    WARN_ON.

    Signed-off-by: Yangtao Li <frank@allwinnertech.com>
    ---
    drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
    index 8e792f8e2dc9..9d8b59dafa4b 100644
    --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
    +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
    @@ -1139,8 +1139,7 @@ static void sunxi_pinctrl_irq_handler(struct irq_desc *desc)
    if (irq == pctl->irq[bank])
    break;

    - if (bank == pctl->desc->irq_banks)
    - return;
    + WARN_ON(bank == pctl->desc->irq_banks);

    reg = sunxi_irq_status_reg_from_bank(pctl->desc, bank);
    val = readl(pctl->membase + reg);
    --
    2.28.0
    \
     
     \ /
      Last update: 2020-11-10 07:24    [W:4.148 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site