lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] powerpc/mm: Fix comparing pointer to 0 warning
    From
    Date


    Le 10/11/2020 à 03:56, xiakaixu1987@gmail.com a écrit :
    > From: Kaixu Xia <kaixuxia@tencent.com>
    >
    > Fixes coccicheck warning:
    >
    > ./arch/powerpc/mm/pgtable_32.c:87:11-12: WARNING comparing pointer to 0
    >
    > Avoid pointer type value compared to 0.
    >
    > Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
    > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>

    Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

    > ---
    > arch/powerpc/mm/pgtable_32.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c
    > index 079159e97bca..888b9713a316 100644
    > --- a/arch/powerpc/mm/pgtable_32.c
    > +++ b/arch/powerpc/mm/pgtable_32.c
    > @@ -84,7 +84,7 @@ int __ref map_kernel_page(unsigned long va, phys_addr_t pa, pgprot_t prot)
    > pg = pte_alloc_kernel(pd, va);
    > else
    > pg = early_pte_alloc_kernel(pd, va);
    > - if (pg != 0) {
    > + if (pg) {
    > err = 0;
    > /* The PTE should never be already set nor present in the
    > * hash table
    >

    \
     
     \ /
      Last update: 2020-11-10 07:08    [W:5.528 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site