lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 25/30] drm/radeon/sumo_dpm: Move 'sumo_get_pi()'s prototype into shared header
    On Tue, Nov 10, 2020 at 2:32 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/radeon/sumo_dpm.c:81:25: warning: no previous prototype for ‘sumo_get_pi’ [-Wmissing-prototypes]
    > 81 | struct sumo_power_info *sumo_get_pi(struct radeon_device *rdev)
    > | ^~~~~~~~~~~
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/radeon/sumo_dpm.h | 1 +
    > drivers/gpu/drm/radeon/sumo_smc.c | 2 --
    > 2 files changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/radeon/sumo_dpm.h b/drivers/gpu/drm/radeon/sumo_dpm.h
    > index f1651135a47ab..db29d37ae2703 100644
    > --- a/drivers/gpu/drm/radeon/sumo_dpm.h
    > +++ b/drivers/gpu/drm/radeon/sumo_dpm.h
    > @@ -207,6 +207,7 @@ u32 sumo_get_sleep_divider_from_id(u32 id);
    > u32 sumo_get_sleep_divider_id_from_clock(struct radeon_device *rdev,
    > u32 sclk,
    > u32 min_sclk_in_sr);
    > +struct sumo_power_info *sumo_get_pi(struct radeon_device *rdev);
    >
    > /* sumo_smc.c */
    > void sumo_initialize_m3_arb(struct radeon_device *rdev);
    > diff --git a/drivers/gpu/drm/radeon/sumo_smc.c b/drivers/gpu/drm/radeon/sumo_smc.c
    > index d781407057366..78d8716067318 100644
    > --- a/drivers/gpu/drm/radeon/sumo_smc.c
    > +++ b/drivers/gpu/drm/radeon/sumo_smc.c
    > @@ -30,8 +30,6 @@
    > #define SUMO_SMU_SERVICE_ROUTINE_ALTVDDNB_NOTIFY 27
    > #define SUMO_SMU_SERVICE_ROUTINE_GFX_SRV_ID_20 20
    >
    > -struct sumo_power_info *sumo_get_pi(struct radeon_device *rdev);
    > -
    > static void sumo_send_msg_to_smu(struct radeon_device *rdev, u32 id)
    > {
    > u32 gfx_int_req;
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-11 01:05    [W:4.161 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site