lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 13/19] drm/radeon/radeon_drv: Move prototypes to a shared headerfile
    On Fri, Nov 6, 2020 at 4:50 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > 62 | void radeon_driver_unload_kms(struct drm_device *dev)
    > | ^~~~~~~~~~~~~~~~~~~~~~~~
    > drivers/gpu/drm/radeon/radeon_kms.c:105:5: warning: no previous prototype for ‘radeon_driver_load_kms’ [-Wmissing-prototypes]
    > 105 | int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)
    > | ^~~~~~~~~~~~~~~~~~~~~~
    > drivers/gpu/drm/radeon/radeon_kms.c:619:6: warning: no previous prototype for ‘radeon_driver_lastclose_kms’ [-Wmissing-prototypes]
    > 619 | void radeon_driver_lastclose_kms(struct drm_device *dev)
    > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    > drivers/gpu/drm/radeon/radeon_kms.c:634:5: warning: no previous prototype for ‘radeon_driver_open_kms’ [-Wmissing-prototypes]
    > 634 | int radeon_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv)
    > | ^~~~~~~~~~~~~~~~~~~~~~
    > drivers/gpu/drm/radeon/radeon_kms.c:705:6: warning: no previous prototype for ‘radeon_driver_postclose_kms’ [-Wmissing-prototypes]
    > 705 | void radeon_driver_postclose_kms(struct drm_device *dev,
    > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: Gareth Hughes <gareth@valinux.com>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/radeon/radeon_drv.c | 6 ------
    > drivers/gpu/drm/radeon/radeon_drv.h | 7 +++++++
    > 2 files changed, 7 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
    > index bb7b33e535f81..e0d664e9e2feb 100644
    > --- a/drivers/gpu/drm/radeon/radeon_drv.c
    > +++ b/drivers/gpu/drm/radeon/radeon_drv.c
    > @@ -112,12 +112,6 @@
    > #define KMS_DRIVER_MAJOR 2
    > #define KMS_DRIVER_MINOR 50
    > #define KMS_DRIVER_PATCHLEVEL 0
    > -int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags);
    > -void radeon_driver_unload_kms(struct drm_device *dev);
    > -void radeon_driver_lastclose_kms(struct drm_device *dev);
    > -int radeon_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv);
    > -void radeon_driver_postclose_kms(struct drm_device *dev,
    > - struct drm_file *file_priv);
    > int radeon_suspend_kms(struct drm_device *dev, bool suspend,
    > bool fbcon, bool freeze);
    > int radeon_resume_kms(struct drm_device *dev, bool resume, bool fbcon);
    > diff --git a/drivers/gpu/drm/radeon/radeon_drv.h b/drivers/gpu/drm/radeon/radeon_drv.h
    > index 173deb4634146..ac7970919c4d3 100644
    > --- a/drivers/gpu/drm/radeon/radeon_drv.h
    > +++ b/drivers/gpu/drm/radeon/radeon_drv.h
    > @@ -118,4 +118,11 @@
    > long radeon_drm_ioctl(struct file *filp,
    > unsigned int cmd, unsigned long arg);
    >
    > +int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags);
    > +void radeon_driver_unload_kms(struct drm_device *dev);
    > +void radeon_driver_lastclose_kms(struct drm_device *dev);
    > +int radeon_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv);
    > +void radeon_driver_postclose_kms(struct drm_device *dev,
    > + struct drm_file *file_priv);
    > +
    > #endif /* __RADEON_DRV_H__ */
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-10 22:59    [W:5.217 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site