lkml.org 
[lkml]   [2020]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 09/10] bus: mhi: core: Move to an error state on mission mode failure
    On Fri, Sep 18, 2020 at 07:02:34PM -0700, Bhaumik Bhatt wrote:
    > If the host receives a mission mode event and by the time it can get
    > to processing it, the register accesses fail implying a connectivity
    > error, MHI should move to an error state. This helps avoid longer wait
    > times from a synchronous power up perspective and accurately reflects
    > the MHI execution environment and power management states.
    >
    > Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>

    Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

    Thanks,
    Mani

    > ---
    > drivers/bus/mhi/core/pm.c | 8 ++++++--
    > 1 file changed, 6 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
    > index bce1f62..16c04ab 100644
    > --- a/drivers/bus/mhi/core/pm.c
    > +++ b/drivers/bus/mhi/core/pm.c
    > @@ -384,10 +384,14 @@ static int mhi_pm_mission_mode_transition(struct mhi_controller *mhi_cntrl)
    > write_lock_irq(&mhi_cntrl->pm_lock);
    > if (MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state))
    > mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl);
    > - write_unlock_irq(&mhi_cntrl->pm_lock);
    >
    > - if (!MHI_IN_MISSION_MODE(mhi_cntrl->ee))
    > + if (!MHI_IN_MISSION_MODE(mhi_cntrl->ee)) {
    > + mhi_cntrl->pm_state = MHI_PM_LD_ERR_FATAL_DETECT;
    > + write_unlock_irq(&mhi_cntrl->pm_lock);
    > + wake_up_all(&mhi_cntrl->state_event);
    > return -EIO;
    > + }
    > + write_unlock_irq(&mhi_cntrl->pm_lock);
    >
    > wake_up_all(&mhi_cntrl->state_event);
    >
    > --
    > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    > a Linux Foundation Collaborative Project
    >

    \
     
     \ /
      Last update: 2020-10-09 18:45    [W:4.360 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site