Messages in this thread | | | Subject | Re: [PATCH] perf jevents: Fix event code for events referencing std arch events | From | John Garry <> | Date | Fri, 9 Oct 2020 12:38:31 +0100 |
| |
On 09/10/2020 12:26, kajoljain wrote: > > On 10/8/20 8:49 PM, John Garry wrote: >> The event code for events referencing std arch events is incorrectly >> evaluated in json_events(). >> >> The issue is that je.event is evaluated properly from try_fixup(), but >> later NULLified from the real_event() call, as "event" may be NULL. >> >> Fix by setting "event" same je.event in try_fixup(). >> >> Also remove support for overwriting event code for events using std arch >> events, as it is not used. > Patch looks good to me. Not sure if any adding any example with this issue > is helpful.
So we get something like this in pmu-events.c:
{ .name = "l1d_cache_wb_victim", .event = "event=0x0", [...] },
But event should "event=0x46".
I can add this if Arnaldo wants a v2.
> > Reviewed-By: Kajol Jain<kjain@linux.ibm.com>
thanks
| |