Messages in this thread | | | Date | Fri, 9 Oct 2020 01:45:00 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver |
| |
Hi Coiby,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201008-200002 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 76c3bdd67d27289b9e407113821eab2a70bbcca6 config: arm64-randconfig-r025-20201008 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 8da0df3d6dcc0dd42740be60b0da4ec201190904) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/dda18d66af0554f1f2b69f9a61335f3de9ec5124 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201008-200002 git checkout dda18d66af0554f1f2b69f9a61335f3de9ec5124 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/qlge/qlge_devlink.c:37:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized] return err; ^~~ drivers/staging/qlge/qlge_devlink.c:19:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 warning generated.
vim +/err +37 drivers/staging/qlge/qlge_devlink.c
16 17 int qlge_health_create_reporters(struct qlge_devlink *priv) 18 { 19 int err; 20 21 struct devlink_health_reporter *reporter; 22 struct devlink *devlink; 23 24 devlink = priv_to_devlink(priv); 25 reporter = 26 devlink_health_reporter_create(devlink, &qlge_reporter_ops, 27 0, 28 priv); 29 if (IS_ERR(reporter)) { 30 netdev_warn(priv->ndev, 31 "Failed to create reporter, err = %ld\n", 32 PTR_ERR(reporter)); 33 return PTR_ERR(reporter); 34 } 35 priv->reporter = reporter; 36 > 37 return err;
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |