lkml.org 
[lkml]   [2020]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] IB/rdmavt: Fix sizeof mismatch
    On Thu, Oct 08, 2020 at 10:52:04AM +0100, Colin King wrote:
    > From: Colin Ian King <colin.king@canonical.com>
    >
    > An incorrect sizeof is being used, struct rvt_ibport ** is not correct,
    > it should be struct rvt_ibport *. Note that since ** is the same size as
    > * this is not causing any issues. Improve this fix by using
    > sizeof(*rdi->ports) as this allows us to not even reference the type
    > of the pointer. Also remove line breaks as the entire statement can
    > fit on one line.
    >
    > Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
    > Fixes: ff6acd69518e ("IB/rdmavt: Add device structure allocation")
    > Signed-off-by: Colin Ian King <colin.king@canonical.com>

    Reviewed-by: Ira Weiny <ira.weiny@intel.com>

    > ---
    > drivers/infiniband/sw/rdmavt/vt.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/drivers/infiniband/sw/rdmavt/vt.c b/drivers/infiniband/sw/rdmavt/vt.c
    > index f904bb34477a..2d534c450f3c 100644
    > --- a/drivers/infiniband/sw/rdmavt/vt.c
    > +++ b/drivers/infiniband/sw/rdmavt/vt.c
    > @@ -95,9 +95,7 @@ struct rvt_dev_info *rvt_alloc_device(size_t size, int nports)
    > if (!rdi)
    > return rdi;
    >
    > - rdi->ports = kcalloc(nports,
    > - sizeof(struct rvt_ibport **),
    > - GFP_KERNEL);
    > + rdi->ports = kcalloc(nports, sizeof(*rdi->ports), GFP_KERNEL);
    > if (!rdi->ports)
    > ib_dealloc_device(&rdi->ibdev);
    >
    > --
    > 2.27.0
    >

    \
     
     \ /
      Last update: 2020-10-08 18:43    [W:3.224 / U:1.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site