lkml.org 
[lkml]   [2020]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/7] mm, page_alloc: remove setup_pageset()
From
Date
On 10/8/20 2:23 PM, Michal Hocko wrote:
> On Thu 08-10-20 13:41:57, Vlastimil Babka wrote:
>> We initialize boot-time pagesets with setup_pageset(), which sets high and
>> batch values that effectively disable pcplists.
>>
>> We can remove this wrapper if we just set these values for all pagesets in
>> pageset_init(). Non-boot pagesets then subsequently update them to the proper
>> values.
>>
>> No functional change.
>>
>> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!

> Btw. where do we initialize pcp->count? I thought that pcp allocator
> zeroes out the allocated memory but alloc_percpu is GFP_KERNEL like.

pageset_init() does:
memset(p, 0, sizeof(*p))

\
 
 \ /
  Last update: 2020-10-08 14:57    [W:0.210 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site