Messages in this thread | | | Subject | Re: mwifiex: fix double free | From | Kalle Valo <> | Date | Thu, 8 Oct 2020 10:46:43 +0000 (UTC) |
| |
trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com> > > clang static analysis reports this problem: > > sdio.c:2403:3: warning: Attempt to free released memory > kfree(card->mpa_rx.buf); > ^~~~~~~~~~~~~~~~~~~~~~~ > > When mwifiex_init_sdio() fails in its first call to > mwifiex_alloc_sdio_mpa_buffer, it falls back to calling it > again. If the second alloc of mpa_tx.buf fails, the error > handler will try to free the old, previously freed mpa_rx.buf. > Reviewing the code, it looks like a second double free would > happen with mwifiex_cleanup_sdio(). > > So set both pointers to NULL when they are freed. > > Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") > Signed-off-by: Tom Rix <trix@redhat.com> > Reviewed-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
53708f4fd9cf mwifiex: fix double free
-- https://patchwork.kernel.org/patch/11815655/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |