lkml.org 
[lkml]   [2020]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted Firmware Service call
    Date
    Hi Andy,

    Thanks for the feedback.

    >-----Original Message-----
    >From: Andy Shevchenko <andy.shevchenko@gmail.com>
    >Sent: Thursday, October 8, 2020 4:46 PM
    >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>
    >Cc: Hunter, Adrian <adrian.hunter@intel.com>; Michal Simek
    ><michal.simek@xilinx.com>; Shevchenko, Andriy
    ><andriy.shevchenko@intel.com>; Ulf Hansson <ulf.hansson@linaro.org>; linux-
    >mmc <linux-mmc@vger.kernel.org>; linux-arm Mailing List <linux-arm-
    >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux-
    >kernel@vger.kernel.org>; Raja Subramanian, Lakshmi Bai
    ><lakshmi.bai.raja.subramanian@intel.com>; Wan Mohamad, Wan Ahmad Zainie
    ><wan.ahmad.zainie.wan.mohamad@intel.com>; Arnd Bergmann
    ><arnd@arndb.de>
    >Subject: Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted
    >Firmware Service call
    >
    >On Thu, Oct 8, 2020 at 5:48 AM <muhammad.husaini.zulkifli@intel.com> wrote:
    >>
    >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
    >>
    >> Add header file to handle API function for device driver to
    >> communicate with Arm Trusted Firmware.
    >
    >Arm -> ARM ?
    I will rename based on Sudeep's mentioned in latest thread
    >
    >...
    >
    >> .../linux/firmware/intel/keembay_firmware.h | 47 +++++++++++++++++++
    >
    >Please, drop dup of 'firmware' in the filename.
    Noted. Will change to keembay.h
    >
    >...
    >
    >> +/*
    >> + * Intel Keembay SOC Firmware API Layer
    >> + *
    >
    >> + * Copyright (C) 2020-2021, Intel Corporation
    >
    >Hello from the future?
    >
    Will edit to Copyright (C) 2020, Intel Corporation
    >> + *
    >> + * Muhammad Husaini Zulkifli <Muhammad.Husaini.Zulkifli@intel.com>
    >
    >Author: ...
    >
    >> + */
    >
    >...
    >
    >> +/*
    >> + * This file defines API function that can be called by device driver
    >> +in order to
    >
    >an API
    >by a device
    Noted 😊
    >
    >> + * communicate with Arm Trusted Firmware.
    >
    >Arm -> ARM ?
    I will rename based on Sudeep's mentioned in latest thread
    >
    >> + */
    >
    >--
    >With Best Regards,
    >Andy Shevchenko
    \
     
     \ /
      Last update: 2020-10-08 12:40    [W:8.102 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site