Messages in this thread | | | Date | Thu, 8 Oct 2020 10:45:01 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted Firmware Service call |
| |
On Thu, Oct 08, 2020 at 10:09:33AM +0800, muhammad.husaini.zulkifli@intel.com wrote: > From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> > > Add header file to handle API function for device driver to communicate > with Arm Trusted Firmware.
[nit] Since it moved to trusted-firmware.org, it is no longer "Arm" Trusted Firmware. It is now called Trusted Firmware - A profile(TF-A) or Trusted Firmware - M profile (TF-M). Please update the subject and the text above. I know it is silly but I am being asked to get this fixed as it may create "confusion"(I don't know details, please don't ask 😁)
Apart from various minor things Andy already pointed out, this looks good. You can add by Ack once the above naming and all things pointed by Andy are fixed.
-- Regards, Sudeep
| |