Messages in this thread | | | Date | Wed, 7 Oct 2020 11:28:11 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2 11/11] drivers/edac: convert pci counters to counter_atomic32 |
| |
On Tue, Oct 06, 2020 at 02:44:42PM -0600, Shuah Khan wrote: > counter_atomic* is introduced to be used when a variable is used as > a simple counter and doesn't guard object lifetimes. This clearly > differentiates atomic_t usages that guard object lifetimes. > > counter_atomic* variables will wrap around to 0 when it overflows and > should not be used to guard resource lifetimes, device usage and > open counts that control state changes, and pm states. > > atomic_t variables used for pci counters keep track of pci parity and > non-parity errors. Convert them to use counter_atomic32. > > Overflow will wrap around and reset the counts as was the case prior to > the conversion. > > Acked-by: Borislav Petkov <bp@suse.de> > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Looks like pure logging. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |