lkml.org 
[lkml]   [2020]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] checkpatch: add new warnings to author signoff checks.
From
Date
On Wed, 2020-10-07 at 00:31 +0530, Dwaipayan Ray wrote:
> On Wed, Oct 7, 2020 at 12:25 AM Joe Perches <joe@perches.com> wrote:
> > On Wed, 2020-10-07 at 00:21 +0530, Dwaipayan Ray wrote:
> > > The author signed-off-by checks are currently very vague.
> > > Cases like same name or same address are not handled separately.
> > >
> > > For example, running checkpatch on commit be6577af0cef
> > > ("parisc: Add atomic64_set_release() define to avoid CPU soft lockups"),
> > > gives:
> >
> > Aren't you still missing emitting an message for cases like
> >
> > From: "J. Random Developer" <jrd@bigcorp.com>
> > [...]
> > Signed-off-by: "J. Random Developer" (BigCorp) <jrd@bigcorp.com>
> >
> > Where a comment does not match?
> >
> >
>
> Yes, messages for comments were not emitted previously too
> cause the same_email_address() function just matches name
> and email (discarding name comments and email comments).
>
> So should I add it to this patch, or should I work on it in a different
> patch perhaps because it involves change on another subroutine?

I suggest adding it to this patch.


\
 
 \ /
  Last update: 2020-10-06 22:10    [W:0.048 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site