Messages in this thread | | | From | Ikjoon Jang <> | Date | Tue, 6 Oct 2020 12:18:25 +0800 | Subject | Re: linux-next: Fixes tag needs some work in the battery tree |
| |
On Tue, Oct 6, 2020 at 11:57 AM Ikjoon Jang <ikjn@chromium.org> wrote: > > On Mon, Oct 5, 2020 at 7:50 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > Hi all, > > > > In commit > > > > f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails") > > > > Fixes tag > > > > Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect) > > > > has these problem(s): > > > > - Target SHA1 does not exist > > > > Maybe you meant > > > > Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect") > > > > Yes, you're right. I guess I made a mistake here. > I'll send a v2 patch.
Oh I'm sorry, it's from linux-next!
I found d6e24aa0bf15 ("power: supply: sbs-battery: keep error code when get_property() fails") on sre/for-next branch with a valid Fixes tag:
power: supply: sbs-battery: keep error code when get_property() fails
Commit c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect) overwrites the original error code returned from internal functions. On such a sporadic i2c error, a user will get a wrong value without errors.
Fixes: 395a7251dc2b (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)
Signed-off-by: Ikjoon Jang <ikjn@chromium.org> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
but there is still a wrong sha-1 hash in the commit message, Sebastian, can you please amend the commit message before merge?
> > Thank you! > > > -- > > Cheers, > > Stephen Rothwell
| |