Messages in this thread | | | Date | Tue, 6 Oct 2020 19:24:36 +0300 | From | Vladimir Oltean <> | Subject | Re: [net v2] net: dsa: microchip: fix race condition |
| |
On Tue, Oct 06, 2020 at 07:21:25PM +0300, Vladimir Oltean wrote: > You forgot to copy Florian's review tag from v1.
Ah, Florian did not leave a review tag in v1. Just a comment:
> don't you need to pair the test for dev->mib_read_internal being non > zero with setting it to zero in ksz_switch_unregister()?
I may be wrong, but I don't think that setting the interval to zero in unregister() would change anything.
| |