Messages in this thread | | | Subject | Re: [PATCH] rtlwifi: rtl8192se: remove duplicated legacy_httxpowerdiff | From | Joe Perches <> | Date | Mon, 05 Oct 2020 21:10:40 -0700 |
| |
On Tue, 2020-10-06 at 11:59 +0800, Chris Chiu wrote: > From: Chris Chiu <chiu@endlessos.org> > > The legacy_httxpowerdiff in rtl8192se is pretty much the same as > the legacy_ht_txpowerdiff for other chips. Use the same name to > keep the consistency. > > Signed-off-by: Chris Chiu <chiu@endlessos.org> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 2 +- > drivers/net/wireless/realtek/rtlwifi/rtl8192se/rf.c | 2 +- > drivers/net/wireless/realtek/rtlwifi/wifi.h | 1 - > 3 files changed, 2 insertions(+), 3 deletions(-)
Then can't all the struct definitions that include legacy_ht_txpowerdiff other than wifi.h delete it too?
$ git grep -P -n '\blegacy_ht_?txpower' -- '*.h' drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.h:162: u8 legacy_ht_txpowerdiff; drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.h:155: u8 legacy_ht_txpowerdiff; drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.h:140: u8 legacy_ht_txpowerdiff; drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.h:170: u8 legacy_ht_txpowerdiff; drivers/net/wireless/realtek/rtlwifi/wifi.h:1969: u8 legacy_httxpowerdiff; /* Legacy to HT rate power diff */ drivers/net/wireless/realtek/rtlwifi/wifi.h:1980: u8 legacy_ht_txpowerdiff; /*Legacy to HT rate power diff */
| |