lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 73/85] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
    Date
    From: Hanks Chen <hanks.chen@mediatek.com>

    [ Upstream commit 39c4dbe4cc363accd676162c24b264f44c581490 ]

    check mtk_is_virt_gpio input parameter,
    virtual gpio need to support eint mode.

    add error handler for the ko case
    to fix this boot fail:
    pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
    lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]

    Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
    Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
    Acked-by: Sean Wang <sean.wang@kernel.org>
    Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
    Link: https://lore.kernel.org/r/1597922546-29633-1-git-send-email-hanks.chen@mediatek.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    index 2f3dfb56c3fa4..35bbe59357088 100644
    --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)

    desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];

    + /* if the GPIO is not supported for eint mode */
    + if (desc->eint.eint_m == NO_EINT_SUPPORT)
    + return virt_gpio;
    +
    if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
    virt_gpio = true;

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-05 17:35    [W:5.313 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site