Messages in this thread | | | Date | Mon, 5 Oct 2020 09:10:07 +0200 (CEST) | From | Miroslav Benes <> | Subject | Re: [PATCH v4 04/29] objtool: Add a pass for generating __mcount_loc |
| |
On Fri, 2 Oct 2020, Josh Poimboeuf wrote:
> On Thu, Oct 01, 2020 at 03:36:12PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 01, 2020 at 03:17:07PM +0200, Miroslav Benes wrote: > > > > > I also wonder about making 'mcount' command separate from 'check'. Similar > > > to what is 'orc' now. But that could be done later. > > > > I'm not convinced more commands make sense. That only begets us the > > problem of having to run multiple commands. > > Agreed, it gets hairy when we need to combine things. I think "orc" as > a separate subcommand was a mistake. > > We should change to something like > > objtool run [--check] [--orc] [--mcount] > objtool dump [--orc] [--mcount]
Yes, that makes sense.
Miroslav
| |