Messages in this thread | | | Date | Mon, 5 Oct 2020 15:07:35 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range() |
| |
On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote: > Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork: > Pass new vma pointer into copy_page_range()"). > > Jason Gunthorpe also reported that the ordering of copy_page_range() is odd. > Since working at it, reorder the parameters to be logical, by (1) always put > the dst_* fields to be before src_* fields, and (2) keep the same type of > parameters together. > > CC: Jason Gunthorpe <jgg@ziepe.ca> > CC: Andrew Morton <akpm@linux-foundation.org> > Reported-by: Kirill A. Shutemov <kirill@shutemov.name> > Signed-off-by: Peter Xu <peterx@redhat.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
-- Kirill A. Shutemov
| |