lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] kthread: do not modify running work
On Mon 2020-10-05 10:38:29, Petr Mladek wrote:
> On Sun 2020-10-04 10:12:13, Hillf Danton wrote:
> > On Fri, 02 Oct 2020 10:32:32 Thomas Gleixner wrote:
> > > So having a consistent behaviour accross all these facilities makes
> > > absolutely sense and I don't agree with your sentiment in the changelog
> > > at all.
> > >
> > > Just because it does not make sense to you is not a justification for
> > > making stuff inconsistent. You still have not provided a technical
> > > reason why this change is needed.
> >
> > Given the queue method, it is no win to modify delayed work from callback
> > in any case because "we are not adding interfaces just because we can."
>
> What about ipmi_kthread_worker_func()? It is delayed work that
> queues itself.

The function name is actually mv88e6xxx_irq_poll() in upstream.

The wrong name came from a patch when I worked on the API and
tried to switch some kthreads to it.

Best Regards,
Petr

\
 
 \ /
  Last update: 2020-10-05 13:18    [W:0.040 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site