Messages in this thread | | | Subject | Re: [PATCH v2] checkpatch: add new warnings to author signoff checks. | From | Joe Perches <> | Date | Mon, 05 Oct 2020 11:23:28 -0700 |
| |
On Mon, 2020-10-05 at 23:09 +0530, Dwaipayan Ray wrote: > The author signed-off-by checks are currently very vague. > Cases like same name or same address are not handled separately. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > + if ($address1 =~ /(\S+)\+\S+(\@.*)/) { > + $address1 = $1.$2;
More common in this code is "$1" . "$2" not $1.$2
> @@ -6891,9 +6917,29 @@ sub process { [] > + # 4 -> names match, addresses excuding mail extensions (subaddresses) match
excluding
perhaps "subaddress detail" instead of "mail extensions (subaddresses)"
And maybe add "from RFC 5233"
> + > + my $sob_msg = "'From: $author' != 'Signed-off-by: $author_sob'"; > + > + if ($authorsignoff == 0) { > + WARN("NO_AUTHOR_SIGN_OFF", > + "Missing Signed-off-by: line by nominal patch author '$author'\n"); > + } elsif ($authorsignoff == 2) { > + WARN("NO_AUTHOR_SIGN_OFF", > + "From:/Signed-off-by: email name mismatch:\n$sob_msg\n");
Still no need for a newline to separate the output message.
| |