lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 7/7] Input: Add "inhibited" property
    Hi Andrzej,

    On Mon, Jun 08, 2020 at 01:22:11PM +0200, Andrzej Pietrasiewicz wrote:
    > @@ -284,8 +284,11 @@ static int input_get_disposition(struct input_dev *dev,
    > case EV_KEY:
    > if (is_event_supported(code, dev->keybit, KEY_MAX)) {
    >
    > - /* auto-repeat bypasses state updates */
    > - if (value == 2) {
    > + /*
    > + * auto-repeat bypasses state updates but repeat
    > + * events are ignored if the key is not pressed
    > + */
    > + if (value == 2 && test_bit(code, dev->key)) {
    > disposition = INPUT_PASS_TO_HANDLERS;
    > break;
    > }

    Is this chunk really part of inhibit support? I'd think we cancel
    autorepeat timer when we are releasing a key, no?

    Thanks.

    --
    Dmitry

    \
     
     \ /
      Last update: 2020-10-05 20:10    [W:2.422 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site