Messages in this thread | | | Subject | Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option | From | Moshe Shemesh <> | Date | Sun, 4 Oct 2020 10:18:11 +0300 |
| |
On 10/3/2020 6:04 PM, Jakub Kicinski wrote: > External email: Use caution opening links or attachments > > > On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote: >>> enum devlink_attr { >>> /* don't change the order or add anything between, this is ABI! */ >>> DEVLINK_ATTR_UNSPEC, >>> @@ -507,6 +524,7 @@ enum devlink_attr { >>> >>> DEVLINK_ATTR_RELOAD_ACTION, /* u8 */ >>> DEVLINK_ATTR_RELOAD_ACTIONS_PERFORMED, /* u64 */ >>> + DEVLINK_ATTR_RELOAD_LIMIT, /* u8 */ >> Hmm, why there could be specified only single "limit"? I believe this >> should be a bitfield. Same for the internal api to the driver. > Hm I was expecting limits to be ordered (in maths sense) but you're > right perhaps that can't be always guaranteed. > > Also - Moshe please double check that there will not be any kdoc > warnings here - I just learned that W=1 builds don't check headers > but I'll fix up my bot by the time you post v2.
Didn't know this tool, but I will. Thanks.
| |