lkml.org 
[lkml]   [2020]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCHSET] epoll cleanups
On Sun, Oct 04, 2020 at 11:08:11AM -0700, Linus Torvalds wrote:
> On Sat, Oct 3, 2020 at 7:36 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Locking and especially control flow in fs/eventpoll.c is
> > overcomplicated. As the result, the code has been hard to follow
> > and easy to fuck up while modifying.
>
> Scanning through the patches they all look superficially ok to me, but
> I'm wondering how much test coverage you have (because I'm wondering
> how much test coverage we have in general for epoll).

Besides the in-tree one (tools/testing/selftests/filesystems/epoll)
and LTP stuff (testcases/kernel/syscalls/epoll) - only davidel's
epoll_test.c. Plus slapped together "let's try to make it go through
that codepath" stuff (combined with printks in fs/eventpoll.c)...

\
 
 \ /
  Last update: 2020-10-04 22:06    [W:0.215 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site