Messages in this thread | | | From | Avri Altman <> | Subject | RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature | Date | Sun, 4 Oct 2020 14:24:00 +0000 |
| |
Please ignore - I was confused with pre-fetch. Sorry, Avri
> -----Original Message----- > From: Avri Altman > Sent: Sunday, October 4, 2020 10:21 AM > To: 'Adrian Hunter' <adrian.hunter@intel.com>; Martin K . Petersen > <martin.petersen@oracle.com>; James E . J . Bottomley <jejb@linux.ibm.com> > Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Alim Akhtar > <alim.akhtar@samsung.com> > Subject: RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature > > > + /* > > + * DeepSleep requires the Immediate flag. DeepSleep state is actually > > + * entered when the link state goes to Hibern8. > > + */ > > + if (pwr_mode == UFS_DEEPSLEEP_PWR_MODE) > > + cmd[1] = 1; > Shouldn't it be bit1, i.e. cmd[1] = 2 ? > > > cmd[4] = pwr_mode << 4; > >
| |