Messages in this thread | | | Date | Sat, 31 Oct 2020 09:51:46 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer) |
| |
On Fri, 30 Oct 2020 22:10:42 -0700 Xie He wrote: > > The usual way of getting rid of old code is to move it to staging/ > > for a few releases then delete it, like Arnd just did with wimax. > > Oh. OK. But I see "include/linux/if_frad.h" is included in > "net/socket.c", and there's still some code in "net/socket.c" related > to it. If we move all these files to "staging/", we need to change the > "include" line in "net/socket.c" to point to the new location, and we > still need to keep a little code in "net/socket.c". So I think if we > move it to "staging/", we can't do this in a clean way.
I'd just place that code under appropriate #ifdef CONFIG_ so we don't forget to remove it later. It's just the dlci_ioctl_hook, right?
Maybe others have better ideas, Arnd?
| |