Messages in this thread | | | Date | Sat, 31 Oct 2020 09:11:43 +0200 | From | Tony Lindgren <> | Subject | Re: [PATCH 4/4] bus: ti-sysc: Fix bogus resetdone warning for cpsw |
| |
* Grygorii Strashko <grygorii.strashko@ti.com> [201030 18:15]: > Hi Tony, > > On 26/10/2020 12:58, Tony Lindgren wrote: > > The cpsw SOFT_RESET register is cleard when out of reset so let's > > add SYSS_QUIRK_RESETDONE_INVERTED flag for cpsw. Otherwise we will > > get bogus "OCP softreset timed out" warnings on boot. > > Not sure if this quirk based approach is right way to move forward here. > > The cpsw/cpgmac is "ti,sysc-omap4-simple" which means sysc_omap4_simple, which, > in turn, has .srst_shift = -ENODEV. > > And above should be enough to avoid both sysc_reset() and sysc_wait_softreset() for such modules.
That sounds like a much better fix indeed, I'll take a look.
Thanks,
Tony
| |