lkml.org 
[lkml]   [2020]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation
    From
    Date
    On 10/30/20 11:19 PM, Pavel Pisa wrote:
    > This driver adds support for the CTU CAN FD open-source IP core.

    Please fix the following checkpatch warnings/errors:

    ----------------------------------------
    drivers/net/can/ctucanfd/ctucanfd_base.c
    ----------------------------------------
    WARNING: Possible repeated word: 'the'
    #296: FILE: drivers/net/can/ctucanfd/ctucanfd_base.c:296:
    + * This check the drivers state and calls the
    + * the corresponding modes to set.

    WARNING: Possible repeated word: 'the'
    #445: FILE: drivers/net/can/ctucanfd/ctucanfd_base.c:445:
    + * This is the CAN error interrupt and it will check the the type of error

    WARNING: quoted string split across lines
    #466: FILE: drivers/net/can/ctucanfd/ctucanfd_base.c:466:
    + netdev_info(ndev, "%s: ISR = 0x%08x, rxerr %d, txerr %d,"
    + " error type %u, pos %u, ALC id_field %u, bit %u\n",

    CHECK: Alignment should match open parenthesis
    #637: FILE: drivers/net/can/ctucanfd/ctucanfd_base.c:637:
    + ctucan_netdev_dbg(ndev, "%s: from 0x%08x to 0x%08x\n",
    + __func__, priv->txb_prio, prio);

    CHECK: Alignment should match open parenthesis
    #673: FILE: drivers/net/can/ctucanfd/ctucanfd_base.c:673:
    + ctucan_netdev_dbg(ndev, "TXI: TXB#%u: status 0x%x\n",
    + txb_idx, status);

    CHECK: Alignment should match open parenthesis
    #808: FILE: drivers/net/can/ctucanfd/ctucanfd_base.c:808:
    + ctucan_netdev_dbg(ndev, "some ERR interrupt: clearing 0x%08x\n",
    + icr.u32);

    total: 0 errors, 3 warnings, 3 checks, 1142 lines checked

    NOTE: For some of the reported defects, checkpatch may be able to
    mechanically convert to the typical style using --fix or --fix-inplace.

    drivers/net/can/ctucanfd/ctucanfd_base.c has style problems, please review.
    -----------------------------------------
    drivers/net/can/ctucanfd/ctucanfd_frame.h
    -----------------------------------------
    CHECK: Please don't use multiple blank lines
    #46: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:46:
    +
    +

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #49: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:49:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #104: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:104:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #120: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:120:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #128: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:128:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #136: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:136:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #154: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:154:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #172: FILE: drivers/net/can/ctucanfd/ctucanfd_frame.h:172:
    + uint32_t u32;

    total: 0 errors, 0 warnings, 8 checks, 189 lines checked

    NOTE: For some of the reported defects, checkpatch may be able to
    mechanically convert to the typical style using --fix or --fix-inplace.

    drivers/net/can/ctucanfd/ctucanfd_frame.h has style problems, please review.
    -----------------------------------
    drivers/net/can/ctucanfd/ctucanfd.h
    -----------------------------------
    total: 0 errors, 0 warnings, 0 checks, 87 lines checked

    drivers/net/can/ctucanfd/ctucanfd.h has no obvious style problems and is ready for submission.
    --------------------------------------
    drivers/net/can/ctucanfd/ctucanfd_hw.c
    --------------------------------------
    CHECK: Please don't use multiple blank lines
    #30: FILE: drivers/net/can/ctucanfd/ctucanfd_hw.c:30:
    +
    +

    WARNING: Possible repeated word: 'from'
    #40: FILE: drivers/net/can/ctucanfd/ctucanfd_hw.c:40:
    + * generated from from IP-XACT/cactus helps to driver to hardware

    CHECK: Alignment should match open parenthesis
    #98: FILE: drivers/net/can/ctucanfd/ctucanfd_hw.c:98:
    +static u32 ctucan_hw_hwid_to_id(union ctu_can_fd_identifier_w hwid,
    + enum ctu_can_fd_frame_format_w_ide type)

    total: 0 errors, 1 warnings, 2 checks, 751 lines checked

    NOTE: For some of the reported defects, checkpatch may be able to
    mechanically convert to the typical style using --fix or --fix-inplace.

    drivers/net/can/ctucanfd/ctucanfd_hw.c has style problems, please review.
    --------------------------------------
    drivers/net/can/ctucanfd/ctucanfd_hw.h
    --------------------------------------
    WARNING: networking block comments don't use an empty /* line, use /* Comment...
    #56: FILE: drivers/net/can/ctucanfd/ctucanfd_hw.h:56:
    +/*
    + * Status macros -> pass "ctu_can_get_status" result

    WARNING: networking block comments don't use an empty /* line, use /* Comment...
    #84: FILE: drivers/net/can/ctucanfd/ctucanfd_hw.h:84:
    +/*
    + * Interrupt macros -> pass "ctu_can_fd_int_sts" result

    CHECK: Alignment should match open parenthesis
    #759: FILE: drivers/net/can/ctucanfd/ctucanfd_hw.h:759:
    +static inline void ctucan_hw_txt_buf_give_command(struct ctucan_hw_priv *priv,
    + union ctu_can_fd_tx_command cmd, u8 buf)

    total: 0 errors, 2 warnings, 1 checks, 935 lines checked

    NOTE: For some of the reported defects, checkpatch may be able to
    mechanically convert to the typical style using --fix or --fix-inplace.

    drivers/net/can/ctucanfd/ctucanfd_hw.h has style problems, please review.
    ---------------------------------------
    drivers/net/can/ctucanfd/ctucanfd_pci.c
    ---------------------------------------
    total: 0 errors, 0 warnings, 0 checks, 316 lines checked

    drivers/net/can/ctucanfd/ctucanfd_pci.c has no obvious style problems and is ready for submission.
    --------------------------------------------
    drivers/net/can/ctucanfd/ctucanfd_platform.c
    --------------------------------------------
    total: 0 errors, 0 warnings, 0 checks, 142 lines checked

    drivers/net/can/ctucanfd/ctucanfd_platform.c has no obvious style problems and is ready for submission.
    ----------------------------------------
    drivers/net/can/ctucanfd/ctucanfd_regs.h
    ----------------------------------------
    CHECK: Please don't use multiple blank lines
    #100: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:100:
    +
    +

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #103: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:103:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #124: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:124:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #217: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:217:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #245: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:245:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #269: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:269:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #305: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:305:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #319: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:319:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #333: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:333:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #347: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:347:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #361: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:361:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #381: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:381:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #407: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:407:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #431: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:431:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #450: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:450:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #465: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:465:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #487: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:487:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #501: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:501:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #515: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:515:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #529: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:529:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #543: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:543:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #557: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:557:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #571: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:571:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #585: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:585:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #599: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:599:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #652: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:652:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #670: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:670:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #688: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:688:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #718: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:718:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #726: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:726:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #756: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:756:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #784: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:784:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #810: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:810:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #863: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:863:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #890: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:890:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #898: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:898:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #906: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:906:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #948: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:948:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #956: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:956:
    + uint32_t u32;

    CHECK: Prefer kernel type 'u32' over 'uint32_t'
    #964: FILE: drivers/net/can/ctucanfd/ctucanfd_regs.h:964:
    + uint32_t u32;

    total: 0 errors, 0 warnings, 40 checks, 971 lines checked

    NOTE: For some of the reported defects, checkpatch may be able to
    mechanically convert to the typical style using --fix or --fix-inplace.

    drivers/net/can/ctucanfd/ctucanfd_regs.h has style problems, please review.

    NOTE: If any of the errors are false positives, please report
    them to the maintainer, see CHECKPATCH in MAINTAINERS.

    Marc

    --
    Pengutronix e.K. | Marc Kleine-Budde |
    Embedded Linux | https://www.pengutronix.de |
    Vertretung West/Dortmund | Phone: +49-231-2826-924 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-10-31 12:36    [W:2.434 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site