lkml.org 
[lkml]   [2020]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.14 v2 ] platform/x86: Corrects warning: missing braces around initializer
From
Date


> On Oct 30, 2020, at 11:52 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> On Fri, Oct 30, 2020 at 08:55:01AM -0700, john.p.donnelly@oracle.com wrote:
>> From: John Donnelly <john.p.donnelly@oracle.com>
>>
>> The assignment statement of a local variable "struct tp_nvram_state s[2] = {0};
>> is not valid for all versions of compilers.
>
> I don't get the subject. IS it backport of existing change to v4.14, or you are
> trying to fix v4.14? If the latter is the case, it's not correct order. Try
> latest vanilla first (v5.10-rc1 as of today) and if there is still an issue,
> submit a patch.

Hi,

It is only intended for 4.14. Why would you back port a commit to a stable tree that emits warnings ?




>
>> Fixes: 515ded02bc4b ("platform/x86: thinkpad_acpi: initialize tp_nvram_state variable")
>>
>> Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
>
> Should not be blank line in between.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

\
 
 \ /
  Last update: 2020-10-30 18:32    [W:0.052 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site