Messages in this thread | | | Date | Fri, 30 Oct 2020 17:01:56 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] ASoC: intel: sof_rt5682: Add quirk for Dooly |
| |
On Fri, Oct 30, 2020 at 04:44:17PM +0000, Lu, Brent wrote: > , Brent Lu wrote:
> > Wondering if patch1 would be enough?
> Dooly has DMI family string " Google_Hatch" so the DMI quirk will overwrite the > driver_data. I asked google but they prefer not removing this string so it seems to > me that one extra DMI quirk is needed.
I think this needs at least a comment otherwise someone might come along later and clean it up.
> The other way is using acpi_dev_present() in probe to update the quirk with correct > codec setting. Which one do you think is better?
I don't have a strong opinion either way. [unhandled content-type:application/pgp-signature] | |