Messages in this thread | | | From | Adam Ford <> | Date | Fri, 30 Oct 2020 07:25:52 -0500 | Subject | Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up |
| |
On Wed, Oct 7, 2020 at 7:51 AM Adam Ford <aford173@gmail.com> wrote: > > On Sun, Sep 27, 2020 at 12:00 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > The PMIC's interrupt is level low and should be pulled up. The PMIC's > > device node had pinctrl-0 property but it lacked pinctrl-names which > > is required to apply the pin configuration. > > > > Thanks for the fixes! > > > Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags") > > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit") > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Tested-by: Adam Ford <aford173@gmail.com> >
Shawn,
Any chance you can apply this series? Without this patch, the pmic driver throws some splat due to a previous fix.
thanks
adam > > --- > > arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi > > index 6de86a4f0ec4..55b36bddd513 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi > > @@ -72,6 +72,7 @@ > > pmic@4b { > > compatible = "rohm,bd71847"; > > reg = <0x4b>; > > + pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_pmic>; > > interrupt-parent = <&gpio1>; > > interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > > -- > > 2.17.1 > >
| |