lkml.org 
[lkml]   [2020]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 5/5] drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
    Date
    Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
    Read-Write file, So we apply it at drm/i915/display to reduce some
    duplicate code.

    Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
    ---
    .../gpu/drm/i915/display/intel_display_debugfs.c | 55 ++--------------------
    1 file changed, 4 insertions(+), 51 deletions(-)

    diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
    index 0bf31f9..8bf839f 100644
    --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
    +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
    @@ -1329,21 +1329,7 @@ static int i915_displayport_test_active_show(struct seq_file *m, void *data)
    return 0;
    }

    -static int i915_displayport_test_active_open(struct inode *inode,
    - struct file *file)
    -{
    - return single_open(file, i915_displayport_test_active_show,
    - inode->i_private);
    -}
    -
    -static const struct file_operations i915_displayport_test_active_fops = {
    - .owner = THIS_MODULE,
    - .open = i915_displayport_test_active_open,
    - .read = seq_read,
    - .llseek = seq_lseek,
    - .release = single_release,
    - .write = i915_displayport_test_active_write
    -};
    +DEFINE_SHOW_STORE_ATTRIBUTE(i915_displayport_test_active);

    static int i915_displayport_test_data_show(struct seq_file *m, void *data)
    {
    @@ -1733,19 +1719,7 @@ static ssize_t i915_hpd_storm_ctl_write(struct file *file,
    return len;
    }

    -static int i915_hpd_storm_ctl_open(struct inode *inode, struct file *file)
    -{
    - return single_open(file, i915_hpd_storm_ctl_show, inode->i_private);
    -}
    -
    -static const struct file_operations i915_hpd_storm_ctl_fops = {
    - .owner = THIS_MODULE,
    - .open = i915_hpd_storm_ctl_open,
    - .read = seq_read,
    - .llseek = seq_lseek,
    - .release = single_release,
    - .write = i915_hpd_storm_ctl_write
    -};
    +DEFINE_SHOW_STORE_ATTRIBUTE(i915_hpd_storm_ctl);

    static int i915_hpd_short_storm_ctl_show(struct seq_file *m, void *data)
    {
    @@ -1811,14 +1785,7 @@ static ssize_t i915_hpd_short_storm_ctl_write(struct file *file,
    return len;
    }

    -static const struct file_operations i915_hpd_short_storm_ctl_fops = {
    - .owner = THIS_MODULE,
    - .open = i915_hpd_short_storm_ctl_open,
    - .read = seq_read,
    - .llseek = seq_lseek,
    - .release = single_release,
    - .write = i915_hpd_short_storm_ctl_write,
    -};
    +DEFINE_SHOW_STORE_ATTRIBUTE(i915_hpd_short_storm_ctl);

    static int i915_drrs_ctl_set(void *data, u64 val)
    {
    @@ -2181,21 +2148,7 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
    return len;
    }

    -static int i915_dsc_fec_support_open(struct inode *inode,
    - struct file *file)
    -{
    - return single_open(file, i915_dsc_fec_support_show,
    - inode->i_private);
    -}
    -
    -static const struct file_operations i915_dsc_fec_support_fops = {
    - .owner = THIS_MODULE,
    - .open = i915_dsc_fec_support_open,
    - .read = seq_read,
    - .llseek = seq_lseek,
    - .release = single_release,
    - .write = i915_dsc_fec_support_write
    -};
    +DEFINE_SHOW_STORE_ATTRIBUTE(i915_dsc_fec_support);

    /**
    * intel_connector_debugfs_add - add i915 specific connector debugfs files
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-10-30 09:33    [W:4.118 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site