Messages in this thread Patch in this message | | | From | Qinglang Miao <> | Subject | [PATCH] scsi: qla2xxx: add missing iounmap() on error in qlafx00_iospace_config | Date | Sat, 31 Oct 2020 10:16:53 +0800 |
| |
Add the missing iounmap() before return from qlafx00_iospace_config in the error handling case when os failed to do ioremap for ha->iobase.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> --- drivers/scsi/qla2xxx/qla_mr.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index ca7306685..c6fcd47de 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -798,13 +798,13 @@ qlafx00_iospace_config(struct qla_hw_data *ha) ql_log_pci(ql_log_warn, ha->pdev, 0x0129, "region #2 not an MMIO resource (%s), aborting\n", pci_name(ha->pdev)); - goto iospace_error_exit; + goto ha_iobase_exit; } if (pci_resource_len(ha->pdev, 2) < BAR2_LEN_FX00) { ql_log_pci(ql_log_warn, ha->pdev, 0x012a, "Invalid PCI mem BAR2 region size (%s), aborting\n", pci_name(ha->pdev)); - goto iospace_error_exit; + goto ha_iobase_exit; } ha->iobase = @@ -812,7 +812,7 @@ qlafx00_iospace_config(struct qla_hw_data *ha) if (!ha->iobase) { ql_log_pci(ql_log_fatal, ha->pdev, 0x012b, "cannot remap MMIO (%s), aborting\n", pci_name(ha->pdev)); - goto iospace_error_exit; + goto ha_iobase_exit; } /* Determine queue resources */ @@ -824,6 +824,8 @@ qlafx00_iospace_config(struct qla_hw_data *ha) return 0; +ha_iobase_exit: + iounmap(ha->cregbase); iospace_error_exit: return -ENOMEM; } -- 2.23.0
| |