Messages in this thread | | | From | Brendan Higgins <> | Date | Fri, 30 Oct 2020 14:29:59 -0700 | Subject | Re: [PATCH] kunit: Fix kunit.py parse subcommand (use null build_dir) |
| |
On Wed, Oct 21, 2020 at 12:16 AM David Gow <davidgow@google.com> wrote: > > When JSON support was added in [1], the KunitParseRequest tuple was > updated to contain a 'build_dir' field, but kunit.py parse doesn't > accept --build_dir as an option. The code nevertheless tried to access > it, resulting in this error: > > AttributeError: 'Namespace' object has no attribute 'build_dir' > > Given that the parser only uses the build_dir variable to set the > 'build_environment' json field, we set it to None (which gives the JSON > 'null') for now. Ultimately, we probably do want to be able to set this, > but since it's new functionality which (for the parse subcommand) never > worked, this is the quickest way of getting it back up and running. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit-fixes&id=21a6d1780d5bbfca0ce9b8104ca6233502fcbf86 > > Fixes: 21a6d1780d5bbfca0ce9b8104ca6233502fcbf86 ("kunit: tool: allow generating test results in JSON") > Signed-off-by: David Gow <davidgow@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Tested-by: Brendan Higgins <brendanhiggins@google.com>
| |