lkml.org 
[lkml]   [2020]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA
From
Date


On 30. 10. 20 1:40, Nick Desaulniers wrote:
> + authors/reviewers of commit fee10bd22678 ("memory: pl353: Add driver
> for arm pl353 static memory controller")
>
> On Thu, Oct 29, 2020 at 12:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> The pl353-smc driver uses module_amba_driver so it has a build
>> dependency on CONFIG_ARM_AMBA:
>>
>> /usr/bin/arm-linux-gnueabi-ld: drivers/memory/pl353-smc.o: in function `pl353_smc_driver_init':
>> pl353-smc.c:(.init.text+0x10): undefined reference to `amba_driver_register'
>>
>> However it still can be compile tested on platforms other than ARM,
>> which in practice is limited to those selecting ARM_AMBA (so only
>> ARM64).

Indeed.

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

\
 
 \ /
  Last update: 2020-10-30 08:00    [W:0.280 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site