Messages in this thread | | | Subject | Re: [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address | From | Anant Thazhemadam <> | Date | Sat, 3 Oct 2020 11:24:34 +0530 |
| |
On 03-10-2020 04:08, David Miller wrote: > From: Anant Thazhemadam <anant.thazhemadam@gmail.com> > Date: Fri, 2 Oct 2020 17:04:13 +0530 > >> But this patch is about ensuring that an uninitialized variable's >> value (whatever that may be) is not set as the ethernet address >> blindly (without any form of checking if get_registers() worked >> as expected, or not). > Right, and if you are going to check for errors then you have to > handle the error properly. > > And the proper way to handle this error is to set a random ethernet > address on the device.
Yes, I've understood that now. I've prepared and tested a v3 accordingly, and will have it sent in soon enough. Thank you so much for this! :)
Thanks, Anant
| |