Messages in this thread Patch in this message | | | From | Coiby Xu <> | Date | Thu, 29 Oct 2020 22:51:55 +0800 | Subject | Re: [PATCH 2/3] watchdog: st_lpc_wdt: remove unnecessary CONFIG_PM_SLEEP |
| |
On Thu, Oct 29, 2020 at 07:58:30AM +0000, Patrice CHOTARD wrote: >Hi Coiby > >On 10/29/20 8:53 AM, Coiby Xu wrote: >> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. >> >> Signed-off-by: Coiby Xu <coiby.xu@gmail.com> >> --- >> drivers/watchdog/st_lpc_wdt.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c >> index 14ab6559c748..c1428d63dc9e 100644 >> --- a/drivers/watchdog/st_lpc_wdt.c >> +++ b/drivers/watchdog/st_lpc_wdt.c >> @@ -248,7 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev) >> return 0; >> } >> >> -#ifdef CONFIG_PM_SLEEP >> static int st_wdog_suspend(struct device *dev) >> { >> struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev); >> @@ -285,7 +284,6 @@ static int st_wdog_resume(struct device *dev) >> >> return 0; >> } >> -#endif >> >> static SIMPLE_DEV_PM_OPS(st_wdog_pm_ops, >> st_wdog_suspend, > >Reviewed-by: Patrice Chotard <patrice.chotard@st.com> > Thank you for reviewing the patch and giving the credit despite the compiling issue with CONFIG_PM_SLEEP disabled as pointed by Guenter and others:)
>Thanks > >Patrice
-- Best regards, Coiby
| |