lkml.org 
[lkml]   [2020]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail
    On Thu, Oct 29, 2020 at 06:44:49PM +0800, Alex Shi wrote:
    > Since the first parameter is only used by head page, it's better to make
    > it explicit.
    >
    > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
    > Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    > Acked-by: Hugh Dickins <hughd@google.com>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > Cc: Matthew Wilcox <willy@infradead.org>
    > Cc: Hugh Dickins <hughd@google.com>
    > Cc: linux-mm@kvack.org
    > Cc: linux-kernel@vger.kernel.org
    > ---
    > mm/huge_memory.c | 12 ++++++------
    > 1 file changed, 6 insertions(+), 6 deletions(-)
    >
    > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    > index 038db815ebba..93c0b73eb8c6 100644
    > --- a/mm/huge_memory.c
    > +++ b/mm/huge_memory.c
    > @@ -2346,19 +2346,19 @@ static void remap_page(struct page *page, unsigned int nr)
    > }
    > }
    >
    > -static void lru_add_page_tail(struct page *page, struct page *page_tail,
    > +static void lru_add_page_tail(struct page *head, struct page *page_tail,

    It may be better to pick either
    head and tail
    or
    page_head and page_tail

    ?

    \
     
     \ /
      Last update: 2020-10-29 14:53    [W:4.114 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site