Messages in this thread | | | Subject | Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute | From | Bastien Nocera <> | Date | Thu, 29 Oct 2020 13:33:28 +0100 |
| |
On Wed, 2020-10-28 at 18:23 +0100, Hans de Goede wrote: > > > It's not meaningless, but rather ambiguous. For a range of 1 to 5, > > is 1 > > high performance, and 5 low power, or vice-versa? > > It is meaningless because the space we are trying to describe with > the > profile-names is not 1 dimensional. E.g. as discussed before cool and > low-power are not necessarily the same thing. If you have a better > way > to word this I'm definitely in favor of improving the text here.
What do you think of:
> +Since numbers are a rather meaningless way to describe platform- profiles
"Since numbers on their own cannot represent the multiple variables that a profile will adjust (power consumption, heat generation, etc.) ..."
> +this API uses strings to describe the various profiles. To make sure that > +userspace gets a consistent experience when using this API this API > +document defines a fixed set of profile-names. Drivers *must* map their > +internal profile representation/names onto this fixed set.
| |