Messages in this thread | | | Date | Thu, 29 Oct 2020 18:24:34 +0800 | Subject | Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings | From | Icenowy Zheng <> |
| |
于 2020年10月29日 GMT+08:00 下午6:13:04, Maxime Ripard <maxime@cerno.tech> 写到: >Hi, > >On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote: >> Document board compatible names for Elimo Engineering Impetus and >Initium >> >> Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com> >> --- >> Documentation/devicetree/bindings/arm/sunxi.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml >b/Documentation/devicetree/bindings/arm/sunxi.yaml >> index 0f23133672a3..55405809ec91 100644 >> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml >> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml >> @@ -898,3 +898,13 @@ properties: >> items: >> - const: xunlong,orangepi-zero-plus2-h3 >> - const: allwinner,sun8i-h3 >> + >> + - description: Elimo Engineering Impetus SoM >> + items: >> + - const: elimo,impetus >> + - const: allwinner,sun8i-s3 >> + >> + - description: Elimo Engineering Initium >> + items: >> + - const: elimo,initium >> + - const: allwinner,sun8i-s3 > >This should be ordered alphabetically, and most importantly, must match >the ones you have in the DT. > >Here, we have kind of a mess already: the Lichee Zero+ uses >,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the >pinecube uses pine64,pinecube, allwinner,sun8i-s3 > >IIRC the S3 and V3 are pretty much the same SoCs, so the first one >seems >to make more sense to me, but then we should fix the pinecube.
I agree with this.
PineCube is originally designed for S3L (which is branded under Allwinner) but switch to S3 finally, so I may made error when adapting.
> >Maxime
| |