lkml.org 
[lkml]   [2020]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs
From
Date
On 10/29/20 3:59 PM, Borislav Petkov wrote:
> On Thu, Oct 29, 2020 at 03:38:43PM -0600, Shuah Khan wrote:
>> All of the other ones should be changed as such. Why add more?
>
> Because a patch should do one thing and one thing only. So a separate
> patch which converts them all in one go should come ontop. But if you
> insist for the ones I'm adding to have error handling, I can do that, of
> course.
>

A separate patch is fine.


if (numwritten < 1) {
+ perror("write failed");

Please add filename to the error message.

Thanks. Since this depends on other changes, it can go through
tip once this error message change is made.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2020-10-29 23:33    [W:0.070 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site