Messages in this thread | | | Subject | Re: [PATCH 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs | From | Shuah Khan <> | Date | Thu, 29 Oct 2020 16:32:43 -0600 |
| |
On 10/29/20 3:59 PM, Borislav Petkov wrote: > On Thu, Oct 29, 2020 at 03:38:43PM -0600, Shuah Khan wrote: >> All of the other ones should be changed as such. Why add more? > > Because a patch should do one thing and one thing only. So a separate > patch which converts them all in one go should come ontop. But if you > insist for the ones I'm adding to have error handling, I can do that, of > course. >
A separate patch is fine.
if (numwritten < 1) { + perror("write failed");
Please add filename to the error message.
Thanks. Since this depends on other changes, it can go through tip once this error message change is made.
thanks, -- Shuah
| |