Messages in this thread | | | Subject | Re: [PATCH v4] cpupower: Provide online and offline CPU information | From | Shuah Khan <> | Date | Thu, 29 Oct 2020 15:33:56 -0600 |
| |
On 10/23/20 9:25 AM, Brahadambal Srinivasan wrote: > When a user tries to modify cpuidle or cpufreq properties on offline > CPUs, the tool returns success (exit status 0) but also does not provide > any warning message regarding offline cpus that may have been specified > but left unchanged. In case of all or a few CPUs being offline, it can be > difficult to keep track of which CPUs didn't get the new frequency or idle > state set. Silent failures are difficult to keep track of when there are a > huge number of CPUs on which the action is performed. > > This patch adds helper functions to find both online and offline CPUs and > print them out accordingly. > > We use these helper functions in cpuidle-set and cpufreq-set to print an > additional message if the user attempts to modify offline cpus. > > Reported-by: Pavithra R. Prakash <pavrampu@in.ibm.com> > Signed-off-by: Brahadambal Srinivasan <latha@linux.vnet.ibm.com> > --- > tools/power/cpupower/utils/cpufreq-set.c | 3 + > tools/power/cpupower/utils/cpuidle-set.c | 4 ++ > tools/power/cpupower/utils/cpupower.c | 8 +++ > tools/power/cpupower/utils/helpers/helpers.h | 12 ++++ > tools/power/cpupower/utils/helpers/misc.c | 66 +++++++++++++++++++- > 5 files changed, 92 insertions(+), 1 deletion(-) > > v1-->v2: Added helper functions to find online and offline CPUs and print them. > v2-->v3: Fixed some build issues > v3-->v4: Fixed the commit log and moved the version summary to the correct place. >
Thank you. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower
Will be included in my next pull request to PM maintainer.
thanks, -- Shuah
| |