Messages in this thread | | | Date | Wed, 28 Oct 2020 09:42:49 -0500 | From | Rob Herring <> | Subject | Re: [PATCH v2] dt-bindings: power/supply: Add ltc4162-l-charger |
| |
On Tue, 27 Oct 2020 08:09:38 +0100, Mike Looijmans wrote: > Add support for the LTC4162-L Li-Ion battery charger. The driver allows > reading back telemetry and to set some charging options like the input > current limit. > > This adds the devicetree bindings. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > v2: Use microohms, add lltc,cell-count > > .../bindings/power/supply/ltc4162-l.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml >
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/ltc4162-l.example.dt.yaml: battery-charger@68: 'lltc,rsnsb', 'lltc,rsnsi' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
See https://patchwork.ozlabs.org/patch/1388291
The base for the patch is generally the last rc1. Any dependencies should be noted.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |