Messages in this thread | | | Date | Wed, 28 Oct 2020 00:08:36 -0700 | From | Guru Das Srinagesh <> | Subject | Re: [PATCH v3 1/2] bindings: pm8941-misc: Convert to YAML and add support for VBUS detection |
| |
On Fri, Oct 23, 2020 at 11:14:09AM -0500, Rob Herring wrote: > On Thu, Oct 22, 2020 at 02:47:43PM -0700, Guru Das Srinagesh wrote: > > From: Anirudh Ghayal <aghayal@codeaurora.org> > > > > Convert bindings to YAML. Also add compatible string that adds support > > for reporting the VBUS status that can be detected via a dedicated PMIC > > pin. > > Converting to yaml and add Vbus support should be 2 patches.
Done.
> > Really, the main pm8941 needs to be converted and then this one > referenced by it.
Could you please explain a bit more on what this might look like?
>
...
> > + > > +description: | > > + Some Qualcomm PMICs have a "misc" module that can be used to detect when > > + the USB ID pin has been pulled low or high. > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > Don't need oneOf for a single entry.
Done.
> > > + - enum: > > + - qcom,pm8941-misc > > + - qcom,pmd-vbus-det > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 2 > > Need 'minItems: 1' if 1 or 2 interrupts is valid.
Done.
> > > + > > + interrupt-names: > > + anyOf: > > + - items: > > Don't need 'anyOf'
Done.
> > > + - enum: > > + - usb_id > > + - usb_vbus > > I think what you want here is: > > minItems: 1 > items: > - const: usb_id > - const: usb_vbus > > Meaning 'usb_id' is always present and 'usb_vbus' is optional 2nd > interrupt.
Done.
> > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - interrupt-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + pmic { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + interrupt-controller; > > + #interrupt-cells = <4>; > > + > > + usb_id: misc@900 { > > + compatible = "qcom,pm8941-misc"; > > + reg = <0x900>; > > + interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>; > > + interrupt-names = "usb_id"; > > + }; > > + }; > > + > > + usb-controller { > > + extcon = <&usb_id>; > > + }; > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > >
| |