Messages in this thread | | | Date | Wed, 28 Oct 2020 16:12:56 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH v5 3/3] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell |
| |
On Wed, 28 Oct 2020 10:09:50 +1000 Pavana Sharma wrote: > The Marvell 88E6393X device is a single-chip integration of a 11-port > Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers > and three 10-Gigabit interfaces. > > This patch adds functionalities specific to mv88e6393x family (88E6393X, > 88E6193X and 88E6191X) > > Signed-off-by: Pavana Sharma <pavana.sharma@digi.com> > --- > Changes in v2: > - Fix a warning (Reported-by: kernel test robot <lkp@intel.com>) > Changes in v3: > - Fix 'unused function' warning > Changes in v4, v5: > - Incorporated feedback from maintainers.
drivers/net/dsa/mv88e6xxx/port.c:29:5: warning: no previous prototype for ‘mv88e6xxx_port_wait_bit’ [-Wmissing-prototypes] 29 | int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, int reg, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/dsa/mv88e6xxx/port.c:29:5: warning: symbol 'mv88e6xxx_port_wait_bit' was not declared. Should it be static? drivers/net/dsa/mv88e6xxx/port.c:29:5: warning: no previous prototype for ‘mv88e6xxx_port_wait_bit’ [-Wmissing-prototypes] 29 | int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, int reg, | ^~~~~~~~~~~~~~~~~~~~~~~
| |